boostorg / boostorg/gil

PNG window bits defaults to 9 instead of defaulting to 15 like in libpng.

Open
#777 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
199
Forks
171
Avg merge
1d 14h
Merged PRs (30d)
10

Description

https://github.com/boostorg/gil/blob/d8c56358fae6302dd2f2e8cc496bcd4535c16183/include/boost/gil/extension/io/png/tags.hpp#L218

The default window bits here should be 15 for a 32k window, to match libpng. Having it set to 9 makes compression much much slower for anyone who uses png_tag with write_view, and there is no stated reason for why this was set to 9.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.