boostorg / boostorg/geometry

nth_element_and_half_boxes::apply uses local variable with same name as function parameter

Open
#649 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
517
Forks
232
PR merge metrics
No merged PRs in 30d

Description

Compiling 1.69 with VS2019's v142 toolset & arguments /std:c++17 /permissive- I get the following:

[...]boost\include\boost\geometry\index\detail\rtree\pack_create.hpp(80,1): warning C4457: declaration of 'median' hides function parameter

followed by several pages of further complaints. I found that renaming the local 'median' to something like 'edge_median' and updating the two usages of the variable (next two lines) the warning went away.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.