boostorg / boostorg/geometry

Incorrect results of boost::geometry::math::smaller

Open
#1,148 0 comments 1 reaction 1 assignee Claimed by @vissarion View on GitHub
Dominant language
C++
Stars
517
Forks
232
PR merge metrics
No merged PRs in 30d

Description

There are some failing tests in [circleCI](https://app.circleci.com/pipelines/github/boostorg/geometry/393/workflows/0f08835f-b25a-4112-b290-47348ca4a762/jobs/19548).

The commit that introduced that fail was https://github.com/boostorg/geometry/commit/092ab9da349dd0dab8b610407b0275b192d0477c in particular the replacement of `boost::minmax_element` with `std::minmax_element`.

However, it appears that the issue is related to `boost::geometry::math::smaller` and the inconsistent (and wrong) results it returns in the case of floating points numbers that are very close each other. e.g. (1, 1-eps), (1, 1-eps/2) etc (where `eps=std::numeric_limits::epsilon()`.

I will dig more into it next week.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.