boostorg / boostorg/foreach

Index variable naming violates cpp identifier rules when used in global namespace

Open
#19 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
11
Forks
37
PR merge metrics
No merged PRs in 30d

Description

The naming of the index variables (eg. [here](https://github.com/boostorg/foreach/blob/develop/include/boost/foreach.hpp#L1107)) violates the identifier naming rules as can be found [here](https://en.cppreference.com/w/cpp/language/identifiers) when used in the global namespace, ie. free global functions.
All of them are starting with a leading underscore (_).
This is problematic when implementing custom checks using clang's libtooling (macros are already replaced).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.