boostorg / boostorg/container_hash

boost/container_hash: Breaking change of boost::hash_value in 1.81.0?

Open
#31 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
39
Forks
61
PR merge metrics
No merged PRs in 30d

Description

In [yuzu](https://github.com/yuzu-emu/yuzu), we are using `boost::hash_value` to compute the hash of a macro program (represented by a `std::vector`):
https://github.com/yuzu-emu/yuzu/blob/09da9da6fb4428e8f305e967c9102dcf4030c5e9/src/video_core/macro/macro.cpp#L90-L108

These values, in turn, are used to determine the macro programs to emulate at a high level for performance reasons:
https://github.com/yuzu-emu/yuzu/blob/09da9da6fb4428e8f305e967c9102dcf4030c5e9/src/video_core/macro/macro_hle.cpp#L467-L549

Upon updating boost to 1.81.0, we have discovered `boost::hash_value` produces completely different values to 1.79.0.

As a result, we have 2 questions:
Is the value returned by `boost::hash_value` meant to be different on 1.81.0 compared to previous releases?
If this is the case, why was this not documented as a potentially breaking change in the changelog?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.