boostorg / boostorg/compute

Please do not set CMAKE_MODULE_PATH.

Open
#874 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
1.7k
Forks
340
PR merge metrics
No merged PRs in 30d

Description

https://github.com/boostorg/compute/blob/36350b7/CMakeLists.txt#L64 sets `CMAKE_MODULE_PATH` and overwrites CMake and possibly toolchain and Compiler/Platform settings.

This prevents users from providing `find_package` scripts or configs that use `include(...` relative to the default or toolchain `CMAKE_MODULE_PATH`.

Please replace it with

```cmake
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
```

like the `hof` library does, or

```cmake
list(INSERT CMAKE_MODULE_PATH 0 ${CMAKE_BINARY_DIR}/cmake)
```

like the `gil` does.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.