boostorg / boostorg/charconv

Implementation headers should be in src/

Open
#248 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Some headers in `detail` seem to only be used in the library implementation (i.e. the `.cpp` files). I think these should be under `src/` to avoid being distributed when installed, even if they are used in the tests. I've found this out while trying to add C++20 module support to the library, where the mental model for headers in the interface unit and the implementation units is different.

Would you be open to a PR applying the changes I suggest?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.