boostorg / boostorg/bloom

[Codestyle] Use of spaces around operators

Open
#7 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
37
Forks
10
PR merge metrics
No merged PRs in 30d

Description

I know codestyle is highly subjective, but I'd like to make a suggestion:

Would you mind adopting a codestyle with spaces around operators?
Without those it looks like a token soup that is hard to parse visually for me.

E.g.:
- `for(std::size_t i=0;i>1):0;`
- `x|=Block(1)<<(h&mask);`

could be:
- `for(std::size_t i = 0; i < k / 8; ++i){`
- `x ? 1 + constexpr_bit_width(x >> 1) : 0;`
- `x |= Block(1) << (h&mask);`

Or at least for "delimiters"
- `for(std::size_t i=0; i>1) : 0;`
- `x |= Block(1)<<(h&mask);`

To me this makes it much easier to see which parts belong together and not miss e.g. the "?", "|" or ";"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.