boostorg / boostorg/asio

C4242 warning at line 511 in serial_port_base.ipp

Open
#392 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.6k
Forks
485
PR merge metrics
No merged PRs in 30d

Description

File asio\impl\serial_port_base.ipp generates warning C4242 at line 511 due to conversion between `unsigned int` and `BYTE`. I have observed this when compiling with Visual Studio 2019 in an MFC project.

the original line:
` storage.ByteSize = value_;`

the addition of a `static cast` fixes the issue in my local copy of the source code.
` storage.ByteSize = static_cast(value_);`

Strictly speaking there is no run time bug, however this issue is troublesome for developers treating warnings as errors.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.