boostorg / boostorg/accumulators

std::abs used without including header in extended_p_square.hpp

Open
#50 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
26
Forks
61
PR merge metrics
No merged PRs in 30d

Description

`std::abs` needs either `` or `` but neither is included. This results in a particularly hairy ambiguous overload problem on some old versions of gcc.

It also may be better to use `std::fabs`, which is intended for [this use case](https://github.com/boostorg/accumulators/blob/14c13370602fe86d134a948943958cab0921ce9c/include/boost/accumulators/statistics/extended_p_square.hpp#L200)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.