boltpkg / boltpkg/bolt

bug(Yarn): replaced relative path to bin with npx and first argument

Open
#253 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.4k
Forks
97
PR merge metrics
No merged PRs in 30d

Description

| Title | Description
| --------------------|------------
| Version | 0.24.2
| Type | Issue
| node | 10.16.0
| Operating System | Ubuntu 18.04 LTS
| Short Description | ENOENT yarn when yarn not present inside bold/node_modules/.bin since there are conditions like inside Runners where .bin path is not linked properly.
| Detailed description| This issue present when we use Codeship Build process. Codeship environment has different way of linking, mapping, caching installed packages so it is not a good option to think that we will have `yarn` installed and linked for us. This pull request introduces simple fix using `npx` command.

## Type of change

- [x] Non Breaking change

# Checklist:

- [x] Replace relative path of `yarn` with `npx` command
- [x] Put `yarn` command inside first argument of execution inside child process
- [x] Fix Tests to fit new flow when using `yarn` with `npx`
- [x] Expected arguments inside `yarn.test.js` are now 2 instead of 1
- [x] Removed `project-bin-path` from dependencies since `npx` is more powerful

```bash
/home/rof/.nvm/versions/node/v10.16.0/bin/yarnpkg -> /home/rof/.nvm/versions/node/v10.16.0/lib/node_modules/yarn/bin/yarn.js
/home/rof/.nvm/versions/node/v10.16.0/lib
└── yarn@1.19.0

⚡️ bolt v0.24.2 (node v10.16.0)
🔎 [1/4] Validating project...
📦 [2/4] Installing project dependencies...
error Error: spawn /home/rof/src/github.com/camplight/consento/node_modules/bolt/node_modules/.bin/yarn ENOENT
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.