bodil / bodil/purescript-signal

Unnecessary recalculation?

Open
#44 3 comments 2 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
PureScript
Stars
260
Forks
41
PR merge metrics
No merged PRs in 30d

Description

Hi, I'm evaluating several FRP solutions for a large-scale project and have been diving into the source code for this library. First of all, kudos for a great library, it's been working great with the prototypes I've been playing with and I'm greatly enjoying using it.

There's one point I don't understand - in the Elm implementation of FRP, signals pass an 'updated' flag through the signal graph to avoid unnecessary recalculation (see from page 28 in [Czaplicki's original paper](https://www.seas.harvard.edu/sites/default/files/files/archived/Czaplicki.pdf), and the [original implementation](https://github.com/elm-lang/core/blob/2.1.0/src/Native/Signal.js) of Elm's signals).

However, I can't seem to find this mechanism in the purescript-signal code - the entire signal graph seems to be updated for every input. Is there a reason for this, and would you accept a pull request to add it to the library?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.