bndr / bndr/pipreqs

probably not necessary inserting of the auto_mix_prep library to the requirements.txt by pipreqs

Open
#281 2 comments 3 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
7.5k
Forks
424
PR merge metrics
No merged PRs in 30d

Description

Hello together,
thank you for your nice little tool. It worked pretty well.
After the usage, I just fund the auto_mix_prep library in the requirements.txt which I did not even have installed while my repository was working correctly in my environment.

Then I had a look in your code and found the following two lines in the "mapping" - file and found the following rows 1046 and 1047:

src:atlas
src:auto_mix_prep

After a look at the pipreqs.py it seems to me like some import from the source folder inside of my repository is causing to add auto_mix_prep to the requirements.txt py pipreqs.

The deletion of the row "src:auto_mix_prep" will probably cause to add the atlas-library.

Is any of these rows necessary? Especially since src is a common name for code inside a repository. These rows will cause the auto_mix_prep to be installed uselessly in really a lot of virtual environments if I understood it correctly.

I would propose to delete these rows if there is no real reason for them.

Contributor guide

Open the contributing guide

Research direction

Inspect the mapping file around rows 1046-1047 and read the source-folder handling in pipreqs.py. Reproduce the reported requirements.txt output with a repository containing a src directory, then verify that the mapping change no longer adds auto_mix_prep unnecessarily while preserving the intended atlas-library behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.