bluelinelabs / bluelinelabs/LoganSquare

Make constructor ParameterizedType(Type) public

Open
#131 0 comments 6 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.2k
Forks
303
PR merge metrics
No merged PRs in 30d

Description

When implementing custom converter of Retrofit, I found LoganSquare.mapperFor(ParameterizedType) is really useful, however, constructor ParameterizedType(Type) isn't public so it's hard to create ParameterizedType.

Example:

``` java
public class ObjectParseConverter implements Converter {
private final Type type;

public ObjectParseConverter(final Type type) {
this.type = type;
}

@Override
public Object convert(final ResponseBody value) throws IOException {
return LoganSquare.parse(value.byteStream(), new ParameterizedType(type));
}
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the ParameterizedType(Type) constructor referenced in the issue and inspect its visibility. Expose that constructor publicly, then verify the Retrofit converter example can instantiate ParameterizedType and run the relevant project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, mobile
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.