bluelinelabs / bluelinelabs/Conductor

Having multiple controllers each with their own option menu

Open
#371 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.9k
Forks
338
PR merge metrics
No merged PRs in 30d

Description

I'm working on creating a dialog using android.view.Dialog and pushing a controller in it. The dialog is opened from another controller.

Both the parent controller (which is showing the dialog) and child controller inside the dialog have `setHasOptionsMenu(true)`. The issue is the same Menu and MenuInflater are passed to all controllers in the Router and that's causing the child menu to show the parents menu items as well.

Is this expected and if so, is there a way to work around it?

Thanks

Contributor guide

Open the contributing guide

Research direction

Start by reading the Router menu handling and the Controller behavior around setHasOptionsMenu(true), focusing on how a parent controller and a controller inside an android.view.Dialog receive the Menu and MenuInflater. Determine whether sharing them is expected and document a concrete workaround or the behavior that should change.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.