bluelinelabs / bluelinelabs/Conductor

View flashes with Fade.In before transition finishes

Open
#331 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.9k
Forks
338
PR merge metrics
No merged PRs in 30d

Description

I'm on the 2.1.5-SNAPSHOT to try out the SharedElementsTransitions.

[This is the issue I'm having.](http://i.imgur.com/W4I0H3T.gifv)
In my app I have `LibraryController` which has a ViewPager. In this scenario a childcontroller, one of the tabs, is pushing a new controller to the router of the parent controller instead of the `LibraryController` router to not show the tabs using with this code:

private void onAlbumClick(Album album, int position) {
String titleSharedElementName = getResources().getString(R.string.transition_tag_title_indexed, position);
String imageSharedElementName = getResources().getString(R.string.transition_tag_image_indexed, position);

getParentController().getRouter()
.pushController(RouterTransaction
.with(new AlbumDetailController(album, position))
.pushChangeHandler(new ArcFadeMoveChangeHandler(titleSharedElementName, imageSharedElementName))
.popChangeHandler(new ArcFadeMoveChangeHandler(titleSharedElementName, imageSharedElementName)));

}

`ArcFadeMoveChangeHandler` is the exact same as used in the Demo to create a shared element transition but for some reason during the transition I can see the view fade in twice, almost like it flashes. The behavior occurs either with the `getParentController()` or not so maybe it's an issue with the transition starting within the `RouterPagerAdapter`?

Contributor guide

Open the contributing guide

Research direction

Reproduce the flash using the SharedElementsTransitions setup and the provided LibraryController flow. Start by inspecting RouterPagerAdapter and ArcFadeMoveChangeHandler, then compare the behavior with the Demo's shared-element transition. Done means the view no longer visibly fades in twice during the transition.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.