bloomberg / bloomberg/ntf-core

[[nodiscard]] for ntsa::Error

Open
#50 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
99
Forks
33
PR merge metrics
No merged PRs in 30d

Description

I was thinking if it can be useful for us to declare `ntsa::Error` as `class [[nodiscard]] ntsa::Error` when the compiler supports this feature.

At the moment such declaration results in a lot of compilation warnings, mainly in test drivers. But as the idea of ntsa::Error is to return an error status from a function it's better to not ignore it.

Contributor guide

Open the contributing guide

Research direction

Start by locating the declaration of ntsa::Error and reviewing the compilation warnings it causes in test drivers. Check how compiler feature support is handled, then verify that supported builds diagnose ignored errors without leaving unintended warnings; done means the declaration is applied consistently and affected tests compile cleanly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.