bloomberg / bloomberg/ntf-core

Fix a typo in groups/ntc/ntca/ntca_interfaceconfig.h

Open Beginner friendly
#252 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
99
Forks
33
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
In file groups/ntc/ntca/ntca_interfaceconfig.h, there is a typo in the variable name. The `minThreads` variable should really be named as `maxThreads`.

**To Reproduce**
The variable is present in the [header file](https://github.com/bloomberg/ntf-core/blob/1b9f72d68a527b9dfac51efbef2a699fff80710d/groups/ntc/ntca/ntca_interfaceconfig.h#L407).

**Expected behavior**
Fix the typo and change the variable name to make it meaningful.

**Screenshots**
N/A

**Environment (please complete the following information):**
- Any environment

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Research direction

Open groups/ntc/ntca/ntca_interfaceconfig.h at the referenced declaration near line 407 and confirm how the variable is named and used. Rename the misleading minThreads variable to maxThreads wherever needed, then verify the project still builds and its relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.