bloomberg / bloomberg/goldpinger

Include PodSpec.nodeName as a label in goldpinger_peers_response_time_s_* metrics

Open
#40 11 comments 5 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
2.7k
Forks
187
PR merge metrics
No merged PRs in 30d

Description

Hey guys!

Happy New Year!!! 🎉

Super cool project, we've recently deployed this in our clusters and it's proving to be super useful.

I was wondering if it would be possible to add a `nodeName` label to these (`goldpinger_peers_response_time_s_*`) metrics so it would be easier to identify the target nodes being probed.

the node name should be available in the `PodSpec.nodeName`

Contributor guide

Open the contributing guide

Research direction

Start by locating the code that defines the goldpinger_peers_response_time_s_* metrics and the Kubernetes PodSpec handling. Confirm how the target pod's PodSpec.nodeName is available, then verify the metrics expose that value as nodeName without breaking existing labels or metric tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, kubernetes, prometheus
Domain
devops, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.