bloomberg / bloomberg/comdb2

Tests simpletimepart and simpletimepartreptimeoutgenerated include test data in logs

Open
#2,404 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.5k
Forks
243
Avg merge
2d 2h
Merged PRs (30d)
37

Description

**Describe the bug**

in output files ./tests/test_62510/logs/simpletimepart62510.testcase and ./tests/test_62510/logs/62510.testcase there are kilobytes of inserts of sample data such as 0xdeadbeaf. This is particularly unhelpful because there is no newline, and so a command that looks at the last few lines of all the logfiles ends up with a lot of rubbish in it.

**To Reproduce**

Look at the logs of these test cases after a test run.

**Expected behavior**

Sample data not appearing.

**Additional context**

Example....

15:27:30> 750,752d749 < "TABLENAME" : "t1", < }, < { 759c756 < (name='testview1', period='test2min', retention=2, nshards=2, version=0, shard0name='t') --- > (name='testview1', period='test2min', retention=2, nshards=1, version=0, shard0name='t') 761d757 < (name='testview1', shardname='t1') 764c760 < (name='RollShards', arg1='testview1', arg2='t2', arg3=NULL) --- > (name='AddShard', arg1='testview1', arg2=NULL, arg3=NULL) 792d787 < (name='DropShard', arg1='t', arg2=NULL, arg3=NULL) 995a991,1063 > (a=100002, b='Moar rows', c=x'deadbeaf') > (a=100003, b='Moar rows', c=x'deadbeaf') > (a=100004, b='Moar rows', c=x'deadbeaf') > (a=100005, b='Moar rows', c=x'deadbeaf') > (a=100006, b='Moar rows', c=x'deadbeaf') > (a=100007, b='Moar rows', c=x'deadbeaf') > (a=100008, b='Moar rows', c=x'deadbeaf') > (a=100009, b='Moar rows', c=x'deadbeaf') > (a=100010, b='Moar rows', c=x'deadbeaf') > (a=100011, b='Moar rows', c=x'deadbeaf') > (a=100012, b='Moar rows', c=x'deadbeaf') > (a=100013, b='Moar rows', c=x'deadbeaf') > (a=100014, b='Moar rows', c=x'deadbeaf') > (a=100015, b='Moar rows', c=x'deadbeaf') > (a=100016, b='Moar rows', c=x'deadbeaf') > (a=100017, b='Moar rows', c=x'deadbeaf') > (a=100018, b='Moar rows', c=x'deadbeaf') > (a=100019, b='Moar rows', c=x'deadbeaf') > (a=100020, b='Moar rows', c=x'deadbeaf') > (a=100021, b='Moar rows', c=x'deadbeaf') > (a=100022, b='Moar rows', c=x'deadbeaf') > (a=100023, b='Moar rows', c=x'deadbeaf') > (a=100024, b='Moar rows', c=x'deadbeaf') > (a=100025, b='Moar rows', c=x'deadbeaf') > (a=100026, b='Moar rows', c=x'deadbeaf') > (a=100027, b='Moar rows', c=x'deadbeaf') > (a=100028, b='Moar rows', c=x'deadbeaf') > (a=100029, b='Moar rows', c=x'deadbeaf') > (a=100030, b='Moar rows', c=x'deadbeaf') > (a=100031, b='Moar rows', c=x'deadbeaf') > (a=100032, b='Moar rows', c=x'deadbeaf') > (a=100033, b='Moar rows', c=x'deadbeaf') > (a=100034, b='Moar rows', c=x'deadbeaf') > (a=100035, b='Moar rows', c=x'deadbeaf') > (a=100036, b='Moar rows', c=x'deadbeaf') > (a=100037, b='Moar rows', c=x'deadbeaf') > (a=100038, b='Moar rows', c=x'deadbeaf') > (a=100039, b='Moar rows', c=x'deadbeaf') > (a=100040, b='Moar rows', c=x'deadbeaf') > (a=100041, b='Moar rows', c=x'deadbeaf') > (a=100042, b='Moar rows', c=x'deadbeaf') > (a=100043, b='Moar rows', c=x'deadbeaf') > (a=100044, b='Moar rows', c=x'deadbeaf') > (a=100045, b='Moar rows', c=x'deadbeaf') > (a=100046, b='Moar rows', c=x'deadbeaf') > (a=100047, b='Moar rows', c=x'deadbeaf') > (a=100048, b='Moar rows', c=x'deadbeaf') > (a=100049, b='Moar rows', c=x'deadbeaf') > (a=100050, b='Moar rows', c=x'deadbeaf') > (a=100051, b='Moar rows', c=x'deadbeaf') > (a=100052, b='Moar rows', c=x'deadbeaf') > (a=100053, b='Moar rows', c=x'deadbeaf') > (a=100054, b='Moar rows', c=x'deadbeaf') > (a=100055, b='Moar rows', c=x'deadbeaf') > (a=100056, b='Moar rows', c=x'deadbeaf') > (a=100057, b='Moar rows', c=x'deadbeaf') > (a=100058, b='Moar rows', c=x'deadbeaf') > (a=100059, b='Moar rows', c=x'deadbeaf') > (a=100060, b='Moar rows', c=x'deadbeaf') > (a=100061, b='Moar rows', c=x'deadbeaf') > (a=100062, b='Moar rows', c=x'deadbeaf') > (a=100063, b='Moar rows', c=x'deadbeaf') > (a=100064, b='Moar rows', c=x'deadbeaf') > (a=100065, b='Moar rows', c=x'deadbeaf') > (a=100066, b='Moar rows', c=x'deadbeaf') > (a=100067, b='Moar rows', c=x'deadbeaf') > (a=100068, b='Moar rows', c=x'deadbeaf') > (a=100069, b='Moar rows', c=x'deadbeaf') > (a=100070, b='Moar rows', c=x'deadbeaf') > (a=100071, b='Moar rows', c=x'deadbeaf') > (a=100072, b='Moar rows', c=x'deadbeaf') > (a=100073, b='Moar rows', c=x'deadbeaf') > (a=100074, b='Moar rows', c=x'deadbeaf') 1123c1191 < (rows updated=12) --- > (rows updated=19) 1125c1193 < (rows updated=12) --- > (rows updated=19) 1127c1195 < (rows updated=12) --- > (rows updated=20) 1129c1197 < (rows updated=12) --- > (rows updated=20) 1131c1199 < (rows updated=12) --- > (rows updated=20) 1133c1201 < (rows updated=13) --- > (rows updated=20) 1135c1203 < (rows updated=13) --- > (rows updated=20) 1137c1205 < (rows updated=13) --- > (rows updated=20) 1139c1207 < (rows updated=13) --- > (rows updated=20) 1141c1209 < (rows updated=13) --- > (rows updated=20) 1143c1211 < (rows updated=12) --- > (rows updated=19) 1145c1213 < (rows updated=12) --- > (rows updated=19) 1147c1215 < (rows updated=12) --- > (rows updated=20)

and so on and so forth :-)

Contributor guide

Open the contributing guide

Research direction

Run the simpletimepart and simpletimepartreptimeoutgenerated test cases, then inspect tests/test_62510/logs/simpletimepart62510.testcase and tests/test_62510/logs/62510.testcase. Trace where the sample inserts are written to these generated logs and ensure the resulting logs no longer contain the repeated sample data while preserving the relevant test output.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
databases, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.