bloomberg / bloomberg/comdb2

single node timeout in make test

Open
#2,392 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.5k
Forks
243
Avg merge
2d 2h
Merged PRs (30d)
37

Description

make test fails with error 124 after four hours , in the testcase systablelockingextralockgenerated .

I don't think #2311 helps.

**To Reproduce**

Steps to reproduce the behavior:
1. Fresh git clone of comdb2 as of today
2. make ; make test
3. See error

**Expected behavior**

I expected make test to pass all tests, and hopefully well within 4 hours.

**Screenshots**

Here is the end of build/Testing/Temporary/LastTest.log:
```
ESTID=66869 running in /tmp/comdb2/tests/test_66869 systable_locking_extralock_generated 13/362
!systable_locking_extralock_generated: creating db systablelockingextralockgenerated66869
!systable_locking_extralock_generated: starting single node
!systable_locking_extralock_generated: waiting until ready
!systable_locking_extralock_generated: started running with timeout 30m at 2020-08-07 13:44:51
!systable_locking_extralock_generated: finished running with timeout 30m at 2020-08-07 14:14:51
!systable_locking_extralock_generated: timeout (logs in /tmp/comdb2/tests/test_66869/logs/systablelockingextralockgenerated66869.testcase)
!systable_locking_extralock_generated: stopping
make[2]: *** [/tmp/comdb2/tests/testcase.mk:59: test] Error 124
make[1]: *** [Makefile:89: systable_locking_extralock_generated] Error 2

Test time = 14460.52 sec
----------------------------------------------------------
Test Failed.
"all-tests" end time: Aug 07 14:18 BST
"all-tests" time elapsed: 04:01:00
----------------------------------------------------------

End testing: Aug 07 14:18 BST
```

However the testcase log file does not seem to contain any error information:

```
:
:
13:45:17> Completed 0 create and drop tables and views
13:45:53> Completed 10 stat_all_tables
13:46:34> Completed 10 write_tables
13:47:13> Completed 20 stat_all_tables
13:48:21> Completed 20 write_tables
13:48:29> Completed 30 stat_all_tables
13:49:53> Completed 40 stat_all_tables
13:49:53> Completed 10 create and drop tables and views
13:50:10> Completed 30 write_tables
13:51:04> Completed 50 stat_all_tables
13:51:57> Completed 40 write_tables
13:52:28> Completed 60 stat_all_tables
Duration 2049 seconds
```

**Environment (please complete the following information):**
- Operating System and Version: [e.g. Ubuntu Linux 18.04]

Ubuntu Linux 20.04.1 AMD64

Contributor guide

Open the contributing guide

Research direction

Start by rerunning `make; make test` and inspect `build/Testing/Temporary/LastTest.log` plus the testcase logs under `/tmp/comdb2/tests/test_66869/logs/systablelockingextralockgenerated66869.testcase`. Trace `systable_locking_extralock_generated` and the failing commands in `tests/testcase.mk:59` and `Makefile:89`; done means the test no longer times out and the full test suite passes within the expected time.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, databases, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.