bloomberg / bloomberg/comdb2

Block "begin", "commit", "rollback" in lua

Open
#1,818 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.5k
Forks
243
Avg merge
2d 2h
Merged PRs (30d)
37

Description

"begin","rollback", "commit" and other non sqlite requests should fail to execute in sqlite.

Steps to reproduce the behavior:
cdb2sql $SPO - <<'EOF'
create procedure rcd version 'v0' {
local function main()
local _,rc0 = db:exec("begin")
local _,rc2 = db:exec("insert into t values (2)")
local __,rc3 = db:exec("rollback")
print("rc0 = "..rc0)
print("rc2 = "..rc2)
print("rc3 = "..rc3)
end
}$$
put default procedure rcd 'v0'
exec procedure rcd()
EOF

Server Output:
rc0 = 0
rc2 = 0
rc3 = 0

The rc0 and rc3 should be set to a proper error. Currently all exec-s succeed and the row is inserted.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.