block / block/radiography

Missing readme information about collectParameterInformation

Open
#172 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
899
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Hello, I was trying to integrate the library into my compose project, but had an issue described in #159, where composable names were empty, even though I was using latest version which should be compatible with compose 1.7

Looking at the sample project, I was able to pinpoint the issue to the missing call to
`currentComposer.collectParameterInformation()` in my application.
The sample app calls it here https://github.com/block/radiography/blob/main/sample-compose/src/main/java/com/squareup/radiography/sample/compose/MainActivity.kt#L12

Adding that, fixed the issue. Likewise, removing it from sample app, reproduced the issue.

Perhaps the README should be updated to reflect that this is needed in order to get full composable names in the output. Unsure if there is any way to have this set automatically

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.