block / block/buzz

Mobile invite sheet: Join retry silently no-ops after claim error

Open Beginner friendly
#1,979 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
32.7k
Forks
4.3k
Avg merge
1d 13h
Merged PRs (30d)
253

Description

## Summary

After a claim error in the mobile invite join sheet, the error UI re-enables **Join**, but tapping it silently does nothing.

## Root cause

`invite_join_sheet.dart` allows the button in the error state, while the provider's `confirmJoin()` returns early unless status is `confirming`.

## Expected behavior

A retry should either:

- allow `confirmJoin()` from both `confirming` and `error`, or
- keep Join disabled and provide an explicit reset/retry path.

Found during the independent review of PR #1957; non-blocking for that PR but should be fixed as a fast-follow.

Contributor guide

Open the contributing guide

Research direction

Start with invite_join_sheet.dart and the provider's confirmJoin() flow. Reproduce a claim error, then verify that Join either retries successfully from the error state or remains disabled with an explicit reset/retry path; the silent no-op should be gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
flutter
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.