blinksh / blinksh/mosh

Error building with Xcode 9.1, because "system" call has been removed

Open
#4 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
9
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Should affect Xcode 9.X generally. The error occurs on line 88 of `src/frontend/iosclient.cc` (`int unused __attribute((unused)) = system( "locale" );`).

A quick workaround is to just comment out the line -- its apparent purpose is to output locale information to the user, in case the locale is not UTF-8 native.

I was able to build and run the blink shell successfully under iOS 11.2.2 after making the above change, but I have not tested the mosh functionality yet (ssh works fine).

Keep up the great work on this awesome project! :-)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at line 88 of src/frontend/iosclient.cc and inspect the system("locale") call that fails with Xcode 9.1. Build the blink shell under an affected Xcode 9.x/iOS environment, then verify the shell and mosh functionality still work without the build error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, ios
Domain
build-system, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.