blinksh / blinksh/blink

Account for smart keys in terminal size with floating keyboard

Open
#1,241 7 comments 0 reactions 0 assignees View on GitHub
support
Dominant language
Swift
Stars
6.9k
Forks
746
PR merge metrics
No merged PRs in 30d

Description

### Checklist

- [x] Using latest version on the [App Store](http://itunes.apple.com/app/id1156707581)
- [x] Read the [docs](http://blink.sh/docs/)
- [x] Searched for [existing GitHub issues](https://github.com/blinksh/blink/issues)

### Configuration

Blink 13.5.12
iOS 14.4.2
iPad Pro

### Describe the bug

With the floating keyboard, when the smart keys are actually showing (#805), the terminal size is not set to accommodate that used space. So the bottom of the screen (e.g., the command line in vi) is hidden.

Without floating keyboard:

![C2B6C496-7951-4817-9066-594FC09266E3](https://user-images.githubusercontent.com/386877/117946681-cf602c80-b30f-11eb-8887-420811016168.png)

with floating keyboard:

![67123364-D487-46B5-9C3B-E8D185006B13](https://user-images.githubusercontent.com/386877/117946792-e737b080-b30f-11eb-9106-d3644fe79dbc.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue on an iPad Pro running iOS 14.4.2 with the floating keyboard and visible smart keys. Start by tracing the terminal sizing and keyboard-handling entry points, then verify that the terminal's bottom row remains visible when smart keys are shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.