bleroy / bleroy/vandelay

GetFaviconSuggestions causes an error in AzureFileSystem

Open Beginner friendly
#32 0 comments 0 reactions 0 assignees View on GitHub
unassigned
Dominant language
C#
Stars
13
Forks
12
PR merge metrics
No merged PRs in 30d

Description

In FaviconService.cs the .GetMediaFolders call with "." as parameter causes an
error at AzureFileSystem.cs as it tries to recreate the folder with path "/."
The parameter should change to null if you want it to work with Azure Modules
enabled.

```
public IEnumerable GetFaviconSuggestions() {
List faviconSuggestions = null;
var rootMediaFolders = _mediaService
.GetMediaFolders(".") // change the parameter to null for Azure Storage
.Where(f => f.Name.Equals(FaviconMediaFolder, StringComparison.OrdinalIgnoreCase));
if (rootMediaFolders.Any()) {
faviconSuggestions = new List(
_mediaService.GetMediaFiles(FaviconMediaFolder)
.Select(f => _mediaService.GetMediaPublicUrl(FaviconMediaFolder, f.Name)));
}
return faviconSuggestions;
}
```
## Work Item Details

**Original CodePlex Issue:** [Issue 36](http://vandelay.codeplex.com/workitem/36)
**Status:** Proposed
**Reason Closed:** Unassigned
**Assigned to:** Unassigned
**Reported on:** Oct 28, 2014 at 10:48 PM
**Reported by:** fotisgpap
**Updated on:** Oct 28, 2014 at 10:48 PM
**Updated by:** fotisgpap
**Status:** Proposed
**Reason Closed:** Unassigned
**Assigned to:** Unassigned
**Reported on:** Oct 28, 2014 at 10:48 PM
**Reported by:** fotisgpap
**Updated on:** Oct 28, 2014 at 10:48 PM
**Updated by:** fotisgpap

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in FaviconService.cs at GetFaviconSuggestions and inspect the GetMediaFolders call, then review AzureFileSystem.cs to understand the "." path failure. Change the parameter as described and verify that favicon suggestions work without recreating the folder as "/." when Azure modules are enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, csharp
Domain
backend, cloud
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.