blaze / blaze/odo

Using "filter_kwargs" on "create_engine" never returns matches

Open
#631 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1k
Forks
131
PR merge metrics
No merged PRs in 30d

Description

In `backends.sql:resource.sql` function, `utils.filter_kwargs` always filters all keywords when creating the engine since `create_engine`'s signature doesn't have any keyword arguments.

https://github.com/blaze/odo/blob/9fce6690b3666160681833540de6c55e922de5eb/odo/backends/sql.py#L633-L640

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.