blaze / blaze/odo

Don't use collate for encoding

Open
#416 0 comments 0 reactions 0 assignees View on GitHub
bug sql
Dominant language
Python
Stars
1k
Forks
131
PR merge metrics
No merged PRs in 30d

Description

I do not thing that the `collate` attribute should turn into the encoding of a `datashape.String`. This is about the sort order. I think we would want to use the encoding of the db for this.

This is also causing a bug when actually specified because it is not in the datashape encoding set.
@osdf

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is named. Locate the handling of the collate attribute and datashape.String encoding, then verify how database encoding and sort order are represented. Done means collate no longer supplies the String encoding and explicitly specifying collate does not produce an invalid datashape encoding.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.