blaze / blaze/odo

Odo 0.4.0 complaining about windows-style line terminators with csv->postgresql

Open
#403 6 comments 0 reactions 0 assignees View on GitHub
bug windows
Dominant language
Python
Stars
1k
Forks
131
PR merge metrics
No merged PRs in 30d

Description

As of 0.4.0, Odo throws a ValueError whenever importing a CSV file with windows style line terminators into PostgreSQL (with error message: "PostgreSQL does not support line terminators other than \n").

However, according to PostgreSQL 9.5 COPY FROM's documentation, "COPY FROM can handle lines ending with newlines, carriage returns, or carriage return/newlines."

Having used Odo 0.3.4 before, I did not have any trouble importing such CSV files.

Therefore, I don't understand why this check and error were introduced?

Sincerely,
Arthur Cheysson

EDIT: forgot the link to relevant page from PostgreSQL's documentation
http://www.postgresql.org/docs/current/static/sql-copy.html

Contributor guide

No contributing guide indexed for this repository

Research direction

Trace the CSV-to-PostgreSQL import path in Odo 0.4.0 and locate the check producing the reported line-terminator error. Compare that behavior with PostgreSQL 9.5 COPY FROM documentation and the earlier Odo 0.3.4 behavior. Done means the import behavior is consistent with the supported terminators and covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, python
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.