black7375 / black7375/Firefox-UI-Fix

Centered bookmar bar doesn't compensate for hidden overflow

Open
#605 0 comments 0 reactions 0 assignees View on GitHub
Class::Layout-Others Component::Toolbar Env::Windows Issue::Bug
Dominant language
SCSS
Stars
5.9k
Forks
202
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

If there's any bookmarks that are hidden due to the not fitting on the bookmark bar, it goes off centre with the `userChrome.centered.bookmarkbar` option enabled.

### Expected behavior

It should always be centred.

### Screenshots

https://user-images.githubusercontent.com/65787561/216786324-dde18aff-5cd7-4d5a-aa3f-4271042ee2ff.mp4

### OS

Windows 10

### OS - Others

_No response_

### Firefox Version

109.0-1

### Distribution

- [x] [Original Lepton](https://github.com/black7375/Firefox-UI-Fix)
- [ ] [Lepton's photon style](https://github.com/black7375/Firefox-UI-Fix/tree/photon-style)
- [ ] [Lepton's proton style](https://github.com/black7375/Firefox-UI-Fix/tree/proton-style)

### Theme

- [ ] Light
- [X] Dark
- [ ] Alpenglow (System: Light)
- [ ] Alpenglow (System: Dark)
- [ ] System Default
- [ ] Others: (e.g. [Photon Colors](https://addons.mozilla.org/en-US/firefox/addon/photon-colors/), [Google Chrome Dark](https://addons.mozilla.org/en-US/firefox/addon/google-chrome-dark/), [Fairytale Of Nature](https://addons.mozilla.org/en-US/firefox/addon/fairytale-of-nature/))

### Theme - More Info

_No response_

### `user.js` setup

User options

userChrome.centered.bookmarkbar: true

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in Firefox 109 on Windows 10 with `userChrome.centered.bookmarkbar: true` and enough bookmarks to overflow the bar. Investigate the SCSS responsible for the centered bookmark bar and verify that the visible bookmarks remain centered when some are hidden.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.