bitwarden / bitwarden/passwordless-dotnet

Improve service registration

Open
#33 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
52
Forks
17
PR merge metrics
No merged PRs in 30d

Description

JIRA item: https://bitwarden.atlassian.net/browse/PAS-206

___

Based on the items raised in the "general feedback" meeting with me and @abergs.

Suggestion 1: rename `AddPasswordlessSdk()` to `AddPassworless()`. The Identity integration should either provide its own overloads with the same name (ideal) or have a separate method, like `AddPasswordlessIdentity()` (less ideal).

Suggestion 2: `AddPasswordlessSdk()` should either be callable without arguments (in which case the `ApiKey`/`ApiSecret` are resolved from conventional environment variables), or the `options => ...` overload should throw an exception when those two values aren't provided.

Contributor guide

Open the contributing guide

Research direction

Start at the AddPasswordlessSdk() service-registration entry point and trace how the ApiKey and ApiSecret options are currently supplied. Clarify the intended naming and Identity integration approach, then define the expected behavior for missing credentials and confirm the chosen registration API is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
developer-experience
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.