bitwarden / bitwarden/clients

Add Login Notification cannot be dismissed with keyboard

Open
#855 3 comments 1 reaction 0 assignees View on GitHub
accessibility browser
Dominant language
TypeScript
Stars
13.8k
Forks
2k
Avg merge
3d 6h
Merged PRs (30d)
340

Description

The notification which shows for adding a new login to your vault cannot be dismissed by any means other than clicking the 'close' icon with your mouse.

Intuitively, and as it is in native browser add login notifications (Firefox, etc.), it should be able to be dismissed by pressing the Esc key on your keyboard. Essentially, the notification should act as a kind of overlay on top of the page, like a modal, that is acting as the top layer of interaction with the keyboard.

For people like me who try to navigate solely through the keyboard (with the help of keyboard shortcuts), small details in functionality like this are important.

This issue was experienced in Chrome, and is likely present in other browsers like Firefox as well. This issue likely exists for the Changed Password Notification too.

Contributor guide

Open the contributing guide

Research direction

Locate the add-login notification and the related changed-password notification in the client, then reproduce the issue in Chrome with keyboard input. Done means both notifications can be dismissed with the Esc key while retaining their existing close-button behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.