bitwarden / bitwarden/clients

[Windows Desktop] Closing the main window does not prompt to save pending changes

Open
#4,729 4 comments 1 reaction 0 assignees View on GitHub
bug desktop
Dominant language
TypeScript
Stars
13.8k
Forks
2k
Avg merge
3d 9h
Merged PRs (30d)
397

Description

### Steps To Reproduce

1. Open the Bitwarden Desktop Client and login.
2. Open a credential entry in the vault.
3. Edit that entry.
4. Generate a new password for that entry, accepting the password override prompt and accepting the new password.
5. Close the window.

### Expected Result

Upon closing the desktop client's window, the app should display a "Would you like to save your pending changes?" prompt for any unsaved changes. This would align with other desktop applications where unsaved work remains.

Additionally, any newly generated passwords should be saved to the vault immediately upon accepting the new password. This was the expected behaviour because a "Would you like to override the existing password" prompt was displayed and accepted, and the window did not resist being closed.

### Actual Result

Upon closing the desktop client's window, the app closes but loses any pending changes. e.g. recently generated passwords

### Screenshots or Videos

_No response_

### Additional Context

_No response_

### Operating System

Windows

### Operating System Version

Win 10 Pro 22H2 (19045.2486)

### Installation method

Direct Download (from bitwarden.com)

### Build Version

2023.1.1

### Issue Tracking Info

- [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the Windows Desktop client using the listed steps, then trace how window closing handles pending vault edits and generated passwords. Done means closing with unsaved changes prompts to save, and an accepted newly generated password is saved to the vault immediately.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.