bitwarden / bitwarden/android

There should be two separate "Autofill" strings (verb/noun)

Open
#4,856 3 comments 1 reaction 0 assignees View on GitHub
app:password-manager bug
Dominant language
Kotlin
Stars
9.4k
Forks
1.1k
Avg merge
1d 14h
Merged PRs (30d)
67

Description

There should be two separate "Autofill" strings in the mobile app, and probably on other's too. One that is a verb for strings that are about triggering the action, and another one as a noun for settings category headers etc. Currently there is only one such string so it must be used for both cases unless I'm missing something.

Not separating nouns and verbs because they are interchancable in English is not a good practice because they often aren't in many other languages (like Finnish in this case). This seems to be quite common issue with many localizations. This is propably one of the most common localization issues along with not providing separate plural forms and instead trying to use a smaller amount of # word(s) to get away with it (for Finnish, this sometimes works, but often not, and when it doesn't it is absolute hell to manage).

The line:
https://github.com/bitwarden/android/blob/ca64ce2176cdb20f8afea74d6824cab92008dc8d/app/src/main/res/values-fi-rFI/strings.xml#L244

At Crowdin this would be string #1438:
https://crowdin.com/editor/bitwarden-mobile/45/en-fi?view=comfortable&filter=basic&value=0#1438

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.