bitwalker / bitwalker/timex

Half-hour negative timezone formatting

Open
#724 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
1.8k
Forks
407
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

Call `Timex.TimezoneInfo.format_offset/1` with a half-hour negative timezone, e.g. `UTC-9:30`.

```
%Timex.TimezoneInfo{abbreviation: "-0930", full_name: "Pacific/Marquesas", offset_std: 0, offset_utc: -34200}
|> Timex.TimezoneInfo.format_offset()
# "-09:-30:00"
```

### Description of issue

Formatting half-hour negative timezones returns `"-09:-30:00"`, and I was expecting `"-09:30:00"`, without that additional minute minus sign. I may be wrong, but is that the conventional formatting for offsets like that?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.