bitwalker / bitwalker/timex

Most functions are incorrect for calendars other than Calendar.ISO

Open
#449 1 comment 0 reactions 0 assignees View on GitHub
feature/enhancement help wanted level:advanced
Dominant language
Elixir
Stars
1.8k
Forks
407
PR merge metrics
No merged PRs in 30d

Description

Most functions in Timex manipulate the Elixir data structures directly. In doing so, they assume a lot about the underlying calendar - in most cases the functions would just not work for anything other than `Calendar.ISO`. The prime example would be `Timex.shift/2`.

Timex should either amend those functions to be correct in case they are called with other calendars, or pattern match on the value and document the functions to only work with `Calendar.ISO`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.