bitwalker / bitwalker/libcluster

General reconnect failure

Open
#148 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
2.2k
Forks
201
PR merge metrics
No merged PRs in 30d

Description

DNS poll, Kubernetes, Kubernetes DNS, Kubernetes DNS SRV and Rancher strategies all don't reconnect nodes case they disconnect for any reason. They need that the backing service discovery also bounces the list, which doesn't always (never?) happen.

This generated the series of PR's https://github.com/bitwalker/libcluster/pull/143, https://github.com/bitwalker/libcluster/pull/144, https://github.com/bitwalker/libcluster/pull/145, https://github.com/bitwalker/libcluster/pull/146 and https://github.com/bitwalker/libcluster/pull/147.

The logic can be greatly simplified by passing the whole list of nodes to `Cluster.Strategy.connect_nodes/4`, as internally it already lists the connected nodes and connect only the "added" ones. Check here: https://github.com/bitwalker/libcluster/blob/master/lib/strategy/strategy.ex#L43.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.