bitwalker / bitwalker/exprotobuf

Broken on Elixir 1.17 with --warnings-as-errors

Open
#117 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
482
Forks
68
PR merge metrics
No merged PRs in 30d

Description

When compiling a project under Elixir 1.17, a warning is produced from `use Protobuf`:

```
warning: using map.field notation (without parentheses) to invoke function Protobuf.Field.record() is deprecated, you must add parentheses instead: remote.function()
(exprotobuf 1.2.17) lib/exprotobuf/utils.ex:100: Protobuf.Utils.convert_from_record/2
(exprotobuf 1.2.17) lib/exprotobuf.ex:226: Protobuf.namespace_fields/3
(elixir 1.17.3) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
(exprotobuf 1.2.17) lib/exprotobuf.ex:207: anonymous fn/5 in Protobuf.namespace_types/3
(elixir 1.17.3) lib/enum.ex:2531: Enum."-reduce/3-lists^foldl/2-0-"/3
...
Compilation failed due to warnings while using the --warnings-as-errors option
```

Since the warning comes from a macro, mix treats the warning as part of the main project and not the dependency. Therefore compilation fails.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.