bitwalker / bitwalker/combine

upper() and lower() don't work as expected

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
200
Forks
20
PR merge metrics
No merged PRs in 30d

Description

This definitely surprised me. The checks are just for == against String.upper and String.lower, which don't do anything with symbols...

```
iex(3)> "[Option" |> Combine.parse(Combine.Parsers.Text.upper())
["["]
iex(4)> "[Option" |> Combine.parse(Combine.Parsers.Text.lower())
["["]
```

I would expect, at least, for those parsers to admit mutually exclusive items.

Something like StreamData would be great for this library.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.