bitshares / bitshares/bsips

BSIP-70 margin call mechanics needs to be adjusted wrt market fees

Open
#254 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
59
Forks
86
PR merge metrics
No merged PRs in 30d

Description

While discussing manual loan closure with @MichelSantos we noticed that the currently specified margin call process does not consider market fees. I. e. the margin call will try to buy back the missing debt, but even if it is filled, after paying market fees the remaining proceeds might not suffice to cover the gap.

This is particularly nasty because the market fee rate can change while the order is sitting on the book. It might be necessary to create/cancel the margin call order in each new block.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.