bitshares / bitshares/bitsharesjs
Implement `varuint64` and replace `varint32`
- Dominant language
- JavaScript
- Stars
- 96
- Forks
- 151
- Avg merge
- 7h 39m
- Merged PRs (30d)
- 2
Description
`varint32` is broken in bitshares-core when data is greater than `0x40000000` aka `1,073,741,824`. Actually everywhere in bitshares-core is using the unsigned format `unsigned_int`. In addition, we're moving forward to 64 bit. Ideally the JS library should support 64 bit too.
Related issues:
* https://github.com/bitshares/bitshares-core/issues/1088
* https://github.com/bitshares/bitshares-fc/pull/64
* https://github.com/bitshares/bitshares-core/issues/993
* https://github.com/bitshares/bitshares-core/pull/1267
Contributor guide
No contributing guide indexed for this repository
Research direction
No files, tests, or entry points are named. Start by locating the varint32 and unsigned_int serialization paths, then read related issues #1088 and #993 and pull requests #64 and #1267; done should include replacing varint32 behavior and supporting the requested 64-bit cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100