bitshares / bitshares/bitshares-ui

Display columns "| Price | Amount | Total | Sum" consistently left to right throughout exchange

Open
#668 3 comments 0 reactions 0 assignees View on GitHub
[3] Enhancement
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

Ordering from left to right PRICE | AMOUNT | TOTAL is very common. Sometimes there is also a 4th column "SUM". The words aren't so important -they are very general- so long as you're consistent.

Given that we are not labeling most of these columns it would be a good idea to remain consistent within the same page to order them in the same way throughout.

Currently we have the above left to right ordering for:
- Asks(horizontal book)
- Market Trades
- My Trades
- Buy and Sell (top to bottom)

We have the opposite ordering (TOTAL | AMOUNT | PRICE) for:
- Bids(horizontal)
- Bids and Asks(vertical book)

I propose we change all these to the same orientation. Reading left to right : Price, Amount, Total (sometimes "SUM").

I understand that not every exchange does this. Bittrex for example has one side of the book reversed similar to ours, however they also label all of their columns so it's not a point of confusion.

I'd also suggest labeling these columns but I understand with such long asset names there is often space constraints. We do at least label them with the coin name that the column is for but because our markets can be flipped, this is not always so helpful.

I've used the word "Amount" here but we currently use the word "Quantity" which is just as good. Amount is a little shorter so it probably works better for space but doesn't really matter, either way, just use the same word, whatever it is.

Related issue:
Use of the word "Total" in the 4th column of the orderbook (I suggest using the word "Sum" instead) is inconsistent with the "Total" used in the Buy and Sell windows. One refers to result of the Price and Amount (aka Total), while the other refers to the sum of all previous results of price and amount (sum of totals)

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by locating the exchange UI components for horizontal and vertical order books, market trades, my trades, and the Buy and Sell windows; compare their column ordering and labels. Done means the relevant views consistently read Price, Amount or Quantity, and Total or Sum from left to right.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.