bitshares / bitshares/bitshares-ui

Integrate "My Markets" and "Find Markets"

Open
#499 32 comments 0 reactions 0 assignees View on GitHub
[3] Enhancement
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

Currently in the Lightwallet and bitshares webwallet. "My Markets" and "Find Markets" provide identical function. Openledgers is different, where within Find Markets you can define your own quote currency. In the Light and Bitshares wallets you are limited to the predefined list of tabs as the quote currency.

Obviously it can be fixed by adopting Openledger's configuration. But I think breaking it into two different tabs is completely unnecessary. All functionality can almost already be done from the My Markets tabs. Simply add a text box "filter" for the quote currency as a tab option. or "+" button to allow the user to add their own tabs.

I've layed out a GUI design here: https://bitsharestalk.org/index.php/topic,25071.new.html#new that shows the additional filter idea. The other ideas in this link arn't related to this issue but i think should be considered possible GUI improvements.

EDIT: In addition: In "My Markets" it is miss labeled as "BASE CURRENCY" when in fact it is the QUOTE CURRENCY.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the existing My Markets and Find Markets screens in the wallet UI, focusing on how quote-currency tabs are configured and where the “BASE CURRENCY” label is rendered. Use the linked GUI design as context. Done means one integrated market view can filter or add quote currencies and the label correctly says “QUOTE CURRENCY”.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.