bitshares / bitshares/bitshares-ui

Instant trade page doesn't represent orders correctly?

Open
#3,776 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Describe the bug**

I'm viewing selling BTS, buying CNY.

It says for 10k BTS I'll get 2 limit orders, however in the astro-ui it's showing more than this.

The user you'll be buying from is also being misrepresented potentially, as one user is shown as having 23.7K BTS available however that's a grouped order at the same price of 0.0280 CNY/BTS.

Instead of 2 limit orders, it should be 3-4.

Also the Price (bitCNY/BTS) is being shown with a price that has greater decimal places than bitCNY permits (4 vs 6-8).

**To Reproduce**

Fetch bid orders via the API, compare against instant trade market orders.

**Expected behavior**

The quantity of limit orders I'll have to broadcast, and who I'm buying from should be accurate.

Prices should also perhaps use correct precisions?

**Screenshots**

Image

**Desktop (please complete the following information):**
web - opera - bts.exchange

Contributor guide

Open the contributing guide

Research direction

Start at the instant trade market-orders view and compare its displayed grouping, seller identity, and price precision with bid orders returned by the API. Done means the displayed limit-order count, buying users, and bitCNY/BTS price precision match the API and asset rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.