bitshares / bitshares/bitshares-ui

Public faucet registered accounts use the same active and memo key?

Open
#3,749 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Describe the bug**

When registering an account using the public faucet, the active and memo keys used are the same in the code

**To Reproduce**

Check out the code: https://github.com/bitshares/bitshares-ui/blob/cfa71452f53a2a09b9774e26dfe1012272bb4e14/app/actions/WalletActions.js#L243

```
memo_key: active_private.private_key
.toPublicKey()
.toPublicKeyString(),
//"memo_key": memo_private.private_key.toPublicKey().toPublicKeyString(),
````

**Expected behavior**

The memo key should be based on the memo_private key converted to a public key string.

This was previously an issue elsewhere in the client: https://github.com/bitshares/bitshares-ui/issues/1569

However as shown in the above code, the fix seems to have been applied to self-created accounts, but not public faucet registered accounts?

Contributor guide

Open the contributing guide

Research direction

Open app/actions/WalletActions.js around line 243 and compare the public faucet registration with the self-created account path. Confirm how memo_private is converted to a public key string and update the public faucet registration so memo_key uses that value. Done when the two keys are derived from their corresponding private keys.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.