bitshares / bitshares/bitshares-ui

AccountAssetCreate app components should get the estimation fees from API and not based on property

Open
#3,720 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Problem:**

Under account asset creation component; the user is expecting to see the asset creation estimation fee; the screen is showing a wrong estimation fees for the user while creating a sub asset.

**Conclusion:**

While the user is creating an assets using the user account page **app/components/Account/AccountAssetCreate.jsx**; the page will use the function **estimateFee** to calculate the estimation fees of the asset creation operation; this function is located under **app/lib/common/trxHelper.js‎**; the function is using static and outdated methods and formulas for calculating the **currentFees**.

**Suggestion:**

To use the core **get_required_fees** **database** API for the function **estimateFee**.

Easiest way perhaps would be replacing the entire function's code here https://github.com/bitshares/bitshares-ui/blob/a5ff713daecef8e98428d67fbd5117a6351badff/app/lib/common/trxHelper.js#L215 to be base on **get_required_fees** **database** API.

Contributor guide

Open the contributing guide

Research direction

Start in app/components/Account/AccountAssetCreate.jsx and app/lib/common/trxHelper.js, locating the estimateFee function and its current fee calculation. Read how the core get_required_fees database API is used elsewhere, then verify that asset creation, including sub asset creation, displays the API-based estimation fee correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.