bitshares / bitshares/bitshares-ui

Credit_offer_accept_operation doesn't show in proposals

Open
#3,661 1 comment 0 reactions 0 assignees View on GitHub
[4c] High Priority
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Describe the bug**

See https://develop.bitshares.org/#/account/blockchain-prize and screenshots below.

This leads to potential on-chain phishing activities.

Victims may think the proposals are free offers and accept them, and end up losing more.

**Additional Context**

There was PR https://github.com/bitshares/bitshares-ui/pull/2704 to render all operations inside proposals, but the related code hasn't been updated for a long time. When new operations got added to the blockchain, they show as a simple "#" in proposals.
I think the idea behind #2704 was to eventually stop using /app/components/Blockchain/OperationAnt.js to render operations, but unfortunately we're still not there yet.

**Screenshots**
![image](https://github.com/bitshares/bitshares-ui/assets/9946777/d4d96c65-98aa-4415-ac8f-eac5884d0790)

![image](https://github.com/bitshares/bitshares-ui/assets/9946777/c40d305b-4a83-4d80-a4cd-3afb905cd199)

Contributor guide

Open the contributing guide

Research direction

Start with /app/components/Blockchain/OperationAnt.js and the proposal-rendering work described in PR #2704, then reproduce the linked proposal page to inspect how credit_offer_accept_operation appears. Done means the operation is rendered with meaningful details in proposals instead of displaying only “#”; verify the affected proposal view after the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.