bitshares / bitshares/bitshares-ui

Reformat all code

Open
#3,418 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

It happens again and again that we have PRs with lots of reformatting and only some business logic change. Let's discuss in here how to format (I personally don't care as long as its clearly defined and consistent), and then do a reformat everything PR. Ideally, we find or pin whatever formatted the existing code, make sure that everyone has that congifured and keep it that way as it was "good" enough imo.

@xiangxn @AmmarYousefM @abitmore preferences?

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the repository's existing formatting setup and the reformatting problems described in recent pull requests. The issue does not name files, tests, or a formatter, so first establish the formatting standard and how it is configured. Done means an agreed, consistent format and a complete reformatting pull request.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.