bitshares / bitshares/bitshares-ui

Support Maker Taker Fees

Open
#3,238 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Is your feature request related to a problem? Please describe.**
post BSIP81 Maker Fees are the old Market Fees and a new fee "Taker" is charged.

The current wallet does not support the Taker and mislabels the Maker as Market

this effects both viewing the potential market fee as the trader
and the updating the market fee as the asset issuer

**Describe the solution you'd like**

exchange

Calculate the maximum of the maker and the taker percentage fee.
Ultimately the user will be charged the maximum or less.
Display this maximum as the market fee at the exchange level.

asset issuance

Additionally, the Asset Create and Asset Update Operations need input commensurate with the equivalent of two market fees; there will still be one "market fee permission" and one "market fee flag" but instead of a market fee parameter, there will be two parameter inputs: one for maker the other for taker.

min and max

additional the maker and taker fees respectively also support min and max ranges which should be exposed at the UI level

min_maker
max_maker
min_taker
max_taker

**Alternatives**
Display both the maker and taker fee to the trader.

**Additional context**
keywords "market_fee_percent" , "marketFeePercent, "BSIP81", "BSIP0081"

Contributor guide

Open the contributing guide

Research direction

Search the wallet for the keywords "market_fee_percent", "marketFeePercent", "BSIP81", and "BSIP0081", then trace the exchange display and Asset Create/Asset Update Operations. Done means maker and taker fees, including min and max values, are represented in the UI and the exchange displays the maximum applicable percentage as the market fee.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
blockchain, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.